[PATCH 2/2] net: stmmac: Add StarFive JH8100 dwmac support

[Krzysztof Kozlowski]

On 09/01/2024 08:25, ChunHau Tan wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
>> Sent: Monday, 8 January, 2024 5:07 PM
>> To: ChunHau Tan <chunhau.tan at starfivetech.com>; David S . Miller
>> <davem at davemloft.net>; Eric Dumazet <edumazet at google.com>; Jakub
>> Kicinski <kuba at kernel.org>; Paolo Abeni <pabeni at redhat.com>; Rob Herring
>> <robh+dt at kernel.org>; Emil Renner Berthing <kernel at esmil.dk>; Rob Herring
>> <robh at kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt at linaro.org>;
>> Conor Dooley <conor+dt at kernel.org>; Maxime Coquelin
>> <mcoquelin.stm32 at gmail.com>; Alexandre Torgue
>> <alexandre.torgue at foss.st.com>; Simon Horman <horms at kernel.org>;
>> Bartosz Golaszewski <bartosz.golaszewski at linaro.org>; Andrew Halaney
>> <ahalaney at redhat.com>; Jisheng Zhang <jszhang at kernel.org>; Uwe
>> Kleine-König <u.kleine-koenig at pengutronix.de>; Russell King
>> <rmk+kernel at armlinux.org.uk>
>> Cc: Leyfoon Tan <leyfoon.tan at starfivetech.com>; JeeHeng Sia
>> <jeeheng.sia at starfivetech.com>; netdev at vger.kernel.org;
>> devicetree at vger.kernel.org; linux-kernel at vger.kernel.org;
>> linux-stm32 at st-md-mailman.stormreply.com;
>> linux-arm-kernel at lists.infradead.org
>> Subject: Re: [PATCH 2/2] net: stmmac: Add StarFive JH8100 dwmac support
>>
>> On 08/01/2024 08:58, Tan Chun Hau wrote:
>>> Add JH8100 dwmac support.
>>>
>>> Signed-off-by: Tan Chun Hau <chunhau.tan at starfivetech.com>
>>> ---
>>>  drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
>> b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
>>> index 5d630affb4d1..373714f6e382 100644
>>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
>>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
>>> @@ -146,6 +146,7 @@ static int starfive_dwmac_probe(struct
>> platform_device *pdev)
>>>
>>>  static const struct of_device_id starfive_dwmac_match[] = {
>>>  	{ .compatible = "starfive,jh7110-dwmac"	},
>>> +	{ .compatible = "starfive,jh8100-dwmac"	},
>>
>> No differences? Then why aren't the devices made compatible with each
>> other?
> There is a difference between JH7110 & JH8110,
> JH7110 has two reset signals (ahb, stmmaceth),
> while JH8110 has only one reset signal (stmmaceth),
> this will be shown in device tree file.

So if you are so picky then again: No differences in the driver? Then
use compatibility or provide real arguments. NAK.

Best regards,
Krzysztof