[PATCH 1/2] clk: Add a devm variant of clk_rate_exclusive_get()

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Thu Jan 4 15:01:18 PST 2024


Hello Stephen,

On Thu, Jan 04, 2024 at 01:38:27PM -0800, Stephen Boyd wrote:
> Quoting Uwe Kleine-König (2024-01-04 10:06:29)
> > On Mon, Dec 18, 2023 at 02:01:41PM +0100, Uwe Kleine-K�nig wrote:
> > > If you don't require to add something like:
> > > 
> > >       ret = clk_rate_exclusive_get(clk);
> > >       if (ret)
> > >               return ret;
> > > 
> > > where we currently have just
> > > 
> > >       clk_rate_exclusive_get(clk);
> > > 
> > > the patch can just be applied (using git am -3) not even hitting a merge
> > > conflict without that other series.
> > 
> > I wonder what you think about this. This devm_clk_rate_exclusive_get()
> > would be very useful and simplify a few more drivers.
> > 
> > Do you intend to take the patch as is, or should I rework it to check
> > for the zero it returns?
> 
> Please check the return value even if it is always zero. The discussion
> about handling the return value can continue in parallel.

The discussion in the other thread died, but maybe that's because of the
holidays. Anyhow, I sent a v2 that checks the return value and intend to
rebase and resend my series making clk_rate_exclusive_get() return void
if there is no further contribution by Maxime in a few months.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20240105/3ad45231/attachment.sig>


More information about the linux-arm-kernel mailing list