[PATCH] pinctrl: st: Return pinctrl_gpio_direction_output to transfer the error

Chen Ni nichen at iscas.ac.cn
Wed Jan 3 00:50:58 PST 2024


Return pinctrl_gpio_direction_output() in order to transfer the error
if it fails.

Fixes: b679d6c06b2b ("treewide: rename pinctrl_gpio_direction_output_new()")
Signed-off-by: Chen Ni <nichen at iscas.ac.cn>
---
 drivers/pinctrl/pinctrl-st.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index 1485573b523c..5d9abd6547d0 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -723,9 +723,8 @@ static int st_gpio_direction_output(struct gpio_chip *chip,
 	struct st_gpio_bank *bank = gpiochip_get_data(chip);
 
 	__st_gpio_set(bank, offset, value);
-	pinctrl_gpio_direction_output(chip, offset);
 
-	return 0;
+	return pinctrl_gpio_direction_output(chip, offset);
 }
 
 static int st_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
-- 
2.25.1




More information about the linux-arm-kernel mailing list