[PATCH v4 7/8] net-device: Use new helpers from overflow.h in netdevice APIs
Gustavo A. R. Silva
gustavo at embeddedor.com
Wed Feb 28 17:36:22 PST 2024
On 2/28/24 19:15, Jakub Kicinski wrote:
> On Wed, 28 Feb 2024 19:03:12 -0600 Gustavo A. R. Silva wrote:
>> On 2/28/24 18:57, Jakub Kicinski wrote:
>>> On Wed, 28 Feb 2024 18:49:25 -0600 Gustavo A. R. Silva wrote:
>>>> struct net_device {
>>>> struct_group_tagged(net_device_hdr, hdr,
>>>> ...
>>>> u32 priv_size;
>>>> );
>>>> u8 priv_data[] __counted_by(priv_size) __aligned(NETDEV_ALIGN);
>>>> }
>>>
>>> No, no, that's not happening.
>>
>> Thanks, one less flex-struct to change. :)
>
> I like the flex struct.
> I don't like struct group around a 360LoC declaration just to avoid
> having to fix up a handful of users.
That's what I mean. If we can prevent the flex array ending up in the
middle of a struct by any means, then I wouldn't have to change the
flex struct.
--
Gustavo
More information about the linux-arm-kernel
mailing list