[PATCH 01/11] misc: atmel-ssc: Convert to platform remove callback returning void

[Nicolas.Ferre at microchip.com]

On 21/02/2024 at 10:53, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Acked-by: Nicolas Ferre <nicolas.ferre at microchip.com>
Thanks Uwe.

> ---
>   drivers/misc/atmel-ssc.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
> index ee590c4a1537..6eac0f335915 100644
> --- a/drivers/misc/atmel-ssc.c
> +++ b/drivers/misc/atmel-ssc.c
> @@ -251,7 +251,7 @@ static int ssc_probe(struct platform_device *pdev)
>          return 0;
>   }
> 
> -static int ssc_remove(struct platform_device *pdev)
> +static void ssc_remove(struct platform_device *pdev)
>   {
>          struct ssc_device *ssc = platform_get_drvdata(pdev);
> 
> @@ -260,8 +260,6 @@ static int ssc_remove(struct platform_device *pdev)
>          mutex_lock(&user_lock);
>          list_del(&ssc->list);
>          mutex_unlock(&user_lock);
> -
> -       return 0;
>   }
> 
>   static struct platform_driver ssc_driver = {
> @@ -271,7 +269,7 @@ static struct platform_driver ssc_driver = {
>          },
>          .id_table       = atmel_ssc_devtypes,
>          .probe          = ssc_probe,
> -       .remove         = ssc_remove,
> +       .remove_new     = ssc_remove,
>   };
>   module_platform_driver(ssc_driver);
> 
> --
> 2.43.0
>