[PATCH 0/3] mfd syscon and altera-sysmgr cleanup

Peter Griffin peter.griffin at linaro.org
Tue Feb 20 03:50:09 PST 2024


Hi,

Whilst implementing a driver similar to altera-sysmgr for exynos
it was noticed during the review feedback that we should only call
of_node_put() if the property is provided otherwise nothing has
taken a reference on the node. Both syscon and altera-sysmgr also
have the same issue which this series fixes.

Another piece of review feedback was not to use extern keyword in
the header file, so I also cleaned that up whilst being here.

regards,

Peter.

Peter Griffin (3):
  mfd: syscon: call of_node_put() only when of_parse_phandle() takes a
    ref
  mfd: syscon: remove extern from function prototypes
  mfd: altera-sysmgr: call of_node_put() only when of_parse_phandle()
    takes a ref

 drivers/mfd/altera-sysmgr.c |  4 +++-
 drivers/mfd/syscon.c        |  4 +++-
 include/linux/mfd/syscon.h  | 25 +++++++++++--------------
 3 files changed, 17 insertions(+), 16 deletions(-)

-- 
2.44.0.rc0.258.g7320e95886-goog




More information about the linux-arm-kernel mailing list