[PATCH] PCI: brcmstb: fix broken brcm_pcie_mdio_write() polling

Florian Fainelli florian.fainelli at broadcom.com
Sat Feb 17 09:27:20 PST 2024



On 2/17/2024 5:37 AM, Stefan Wahren wrote:
> From: Jonathan Bell <jonathan at raspberrypi.com>
> 
> MDIO_WR_DONE() tests bit 31, which is always 0 (==done) as
> readw_poll_timeout_atomic does a 16-bit read. Replace with the readl
> variant.
> 
> Fixes: ca5dcc76314d ("PCI: brcmstb: Replace status loops with read_poll_timeout_atomic()")
> Signed-off-by: Jonathan Bell <jonathan at raspberrypi.com>
> Signed-off-by: Stefan Wahren <wahrenst at gmx.net>

Excellent catch! Not sure what the real world impact was.

Acked-by: Florian Fainelli <florian.fainelli at broadcom.com>
-- 
Florian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4221 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20240217/9690f1ee/attachment.p7s>


More information about the linux-arm-kernel mailing list