[PATCH v8 0/3] Add ECC feature support to Tx and Rx FIFOs for Xilinx CAN Controller.

Goud, Srinivas srinivas.goud at amd.com
Thu Feb 15 05:59:33 PST 2024


Hi Marc,

>-----Original Message-----
>From: Marc Kleine-Budde <mkl at pengutronix.de>
>Sent: Tuesday, February 13, 2024 4:07 PM
>To: Appana Durga Kedareswara rao <appana.durga.rao at xilinx.com>; Naga
>Sureshkumar Relli <naga.sureshkumar.relli at xilinx.com>; Wolfgang Grandegger
><wg at grandegger.com>; Marc Kleine-Budde <mkl at pengutronix.de>; David S.
>Miller <davem at davemloft.net>; Eric Dumazet <edumazet at google.com>;
>Jakub Kicinski <kuba at kernel.org>; Paolo Abeni <pabeni at redhat.com>; Rob
>Herring <robh+dt at kernel.org>; Krzysztof Kozlowski
><krzysztof.kozlowski+dt at linaro.org>; Conor Dooley <conor+dt at kernel.org>;
>Simek, Michal <michal.simek at amd.com>
>Cc: linux-can at vger.kernel.org; netdev at vger.kernel.org;
>devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-
>kernel at vger.kernel.org; Goud, Srinivas <srinivas.goud at amd.com>; Conor
>Dooley <conor.dooley at microchip.com>
>Subject: [PATCH v8 0/3] Add ECC feature support to Tx and Rx FIFOs for Xilinx
>CAN Controller.
>
>ECC is an IP configuration option where counter registers are added in IP for
>1bit/2bit ECC errors count and reset.
>
>Also driver reports 1bit/2bit ECC errors for FIFOs based on ECC error interrupts.
>
>Add xlnx,has-ecc optional property for Xilinx AXI CAN controller to support ECC
>if the ECC block is enabled in the HW.
>
>Add ethtool stats interface for getting all the ECC errors information.
>
>There is no public documentation for it available.
>
>Changes in v8:
>- Use u64_stats_sync instead of spinlock
>- Renamed stats strings: use "_" instead of "-"
>- Renamed stats strings: add "_errors" trailer
>- Renamed stats variables similar to stats strings
>
>Changes in v7:
>- Update with spinlock only for stats counters
>
>Changes in v6:
>- Update commit description
>
>Changes in v5:
>- Fix review comments
>- Change the sequence of updates the stats
>- Add get_strings and get_sset_count stats interface
>- Use u64 stats helper function
>
>Changes in v4:
>- Fix DT binding check warning
>- Update xlnx,has-ecc property description
>
>Changes in v3:
>- Update mailing list
>- Update commit description
>
>Changes in v2:
>- Address review comments
>- Add ethtool stats interface
>- Update commit description
>
>---
>Srinivas Goud (3):
>      dt-bindings: can: xilinx_can: Add 'xlnx,has-ecc' optional property
>      can: xilinx_can: Add ECC support
>      can: xilinx_can: Add ethtool stats interface for ECC errors
>
> .../devicetree/bindings/net/can/xilinx,can.yaml    |   5 +
> drivers/net/can/xilinx_can.c                       | 169 ++++++++++++++++++++-
> 2 files changed, 170 insertions(+), 4 deletions(-)
>---
>base-commit: a3522a2edb3faf8cb98d38c2a99f5967beef24e2
>change-id: 20240213-xilinx_ecc-8310f5556010
>
>Best regards,
>--
>Marc Kleine-Budde <mkl at pengutronix.de>
>

Thanks, tested with v8 changes, it is working fine.

Thanks,
Srinivas


More information about the linux-arm-kernel mailing list