[PATCH v7 08/10] coresight-tpdm: Add timestamp control register support for the CMB

Suzuki K Poulose suzuki.poulose at arm.com
Tue Feb 13 03:04:22 PST 2024


On 13/02/2024 10:45, Arnd Bergmann wrote:
> On Tue, Feb 13, 2024, at 11:22, Suzuki K Poulose wrote:
> 
>> coresight: tpdm: Fix build break due to uninitialised field
>>
>> {CMB/DSB}_PATT_ENABLE_TS attributes do not use an index field.
>> But some compilers complain for uninitialised "index" field in
>> the struct tpdm_dataset_attribute:
>>
> ...
>>
>> Reported-by: Arnd Bergmann <arnd at arndb.de>
>> Cc: Tao Zhang <quic_taozha at quicinc.com>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose at arm.com>
> 
> Works fine here with this, thanks for the fix!
> 
> Acked-by: Arnd Bergmann <arnd at arndb.de>
> 
> I had actually missed that this is a warning option that
> is normally disabled even at W=1 level, but it does get
> added by drivers/hwtracing/coresight/Makefile setting
> -Wextra again because that comes after the
> -Wno-missing-field-initializers from scripts/Makefile.extrawarn.
> 
>      Arnd


Thanks for verifying, I have queued this.

https://git.kernel.org/coresight/c/c099fdd218a0

Suzuki



More information about the linux-arm-kernel mailing list