[PATCH v1 2/2] KVM: arm64: removed unused kern_hyp_va asm macro
Marc Zyngier
maz at kernel.org
Thu Feb 8 04:42:25 PST 2024
On Thu, 08 Feb 2024 10:54:22 +0000,
Joey Gouly <joey.gouly at arm.com> wrote:
>
> The last usage of this macro was removed in:
> commit 5dc33bd199ca ("KVM: arm64: nVHE: Pass pointers consistently to hyp-init")
>
> Signed-off-by: Joey Gouly <joey.gouly at arm.com>
> Cc: Marc Zyngier <maz at kernel.org>
> Cc: Oliver Upton <oliver.upton at linux.dev>
> ---
> arch/arm64/include/asm/kvm_mmu.h | 21 ---------------------
> 1 file changed, 21 deletions(-)
>
> diff --git a/arch/arm64/include/asm/kvm_mmu.h b/arch/arm64/include/asm/kvm_mmu.h
> index d248a7ae627a..961d4431654b 100644
> --- a/arch/arm64/include/asm/kvm_mmu.h
> +++ b/arch/arm64/include/asm/kvm_mmu.h
> @@ -53,27 +53,6 @@
>
> #include <asm/alternative.h>
>
> -/*
> - * Convert a kernel VA into a HYP VA.
> - * reg: VA to be converted.
> - *
> - * The actual code generation takes place in kvm_update_va_mask, and
> - * the instructions below are only there to reserve the space and
> - * perform the register allocation (kvm_update_va_mask uses the
> - * specific registers encoded in the instructions).
Consider moving this comment to the C version instead of deleting it
completely (the part about the register allocation is pretty crucial).
Oliver can probably fix this when applying it, and my previous Ack
still stands.
M.
--
Without deviation from the norm, progress is not possible.
More information about the linux-arm-kernel
mailing list