[PATCH v2] spi: imx: fix the burst length at DMA mode and CPU mode

[Carlos Song]

> -----Original Message-----
> From: Francesco Dolcini <francesco at dolcini.it>
> Sent: Thursday, February 1, 2024 4:52 PM
> To: Carlos Song <carlos.song at nxp.com>
> Cc: Francesco Dolcini <francesco at dolcini.it>; broonie at kernel.org;
> shawnguo at kernel.org; s.hauer at pengutronix.de; kernel at pengutronix.de;
> dl-linux-imx <linux-imx at nxp.com>; benjamin at bigler.one;
> stefanmoring at gmail.com; linux-spi at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org
> Subject: [EXT] Re: [PATCH v2] spi: imx: fix the burst length at DMA mode and CPU
> mode
> 
> Caution: This is an external email. Please take care when clicking links or opening
> attachments. When in doubt, report the message using the 'Report this email'
> button
> 
> 
> On Thu, Feb 01, 2024 at 02:02:36AM +0000, Carlos Song wrote:
> > > From: Francesco Dolcini <francesco at dolcini.it> Add #include
> > > <linux/bits.h> given you are using BITS_PER_BYTE
> > >
> > I found that <linux/property.h> has been included in spi-imx.c driver.
> > And <linux/bits.h> has been included in <linux/property.h>.
> > So I didn't add the "#include <linux/bits.h>" on purpose.
> 
> I think you should be explicit and include this header.
> Code get refactored all the time and you can prevent issues this way.
> 
Hi，
Thank you! This is acceptable, I will include <linux/bits.h> explicitly and send V3.

BR
Carlos

> Francesco
>