[PATCH v3 5/6] arm64: dts: imx8mp: Add fsl,dsp-ctrl property for dsp

Krzysztof Kozlowski krzk at kernel.org
Wed Dec 11 01:06:58 PST 2024


On Tue, Dec 10, 2024 at 02:53:37PM +0200, Daniel Baluta wrote:
> Audio block control contains a set of registers some of them used for
> DSP configuration.
> 
> Drivers (rproc, SOF) are using fsl,dsp-ctrl property to access those
> registers in order to control the operations of the DSP (e.g for
> start, reset, etc).

This should have been implemented as reset controller, not syscon. It's
really poor choice to call everything syscon. It does not scale, does
not provide you runtime PM or probe ordering (device links). Quick look
at your drivers suggest that you have exacvtly that problems.

Best regards,
Krzysztof




More information about the linux-arm-kernel mailing list