[PATCH] arm64: dts: exynosautov920: add DMA nodes

Faraz Ata faraz.ata at samsung.com
Tue Dec 10 03:53:09 PST 2024


Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk at kernel.org>
> Sent: Monday, December 9, 2024 1:04 PM
> To: Faraz Ata <faraz.ata at samsung.com>; devicetree at vger.kernel.org; linux-
> samsung-soc at vger.kernel.org; krzk+dt at kernel.org; robh at kernel.org
> Cc: linux-arm-kernel at lists.infradead.org; alim.akhtar at samsung.com;
> rosa.pila at samsung.com
> Subject: Re: [PATCH] arm64: dts: exynosautov920: add DMA nodes
> 
> On 04/12/2024 13:23, Faraz Ata wrote:
> > +
> > +		spdma1: dma-controller at 10190000 {
> > +			compatible = "arm,pl330", "arm,primecell";
> > +			reg = <0x10190000 0x1000>;
> > +			interrupts = <GIC_SPI 917 IRQ_TYPE_LEVEL_HIGH>;
> > +			clocks = <&cmu_misc
> CLK_MOUT_MISC_NOC_USER>;
> > +			clock-names = "apb_pclk";
> > +			#dma-cells = <1>;
> > +		};
> > +
> > +		pdma0: dma-controller at 101A0000 {
> 
> Please do not send downstream code directly, but fix it to match upstream.
> Lowercase hex everywhere.
> 
Thanks for your review,  will takecare in future patches. 

> Best regards,
> Krzysztof




More information about the linux-arm-kernel mailing list