[PATCH V2] pwm: stm32-lp: Add check for clk_enable()

Uwe Kleine-König ukleinek at kernel.org
Fri Dec 6 08:53:08 PST 2024


On Fri, Dec 06, 2024 at 08:12:57AM +0100, Uwe Kleine-König wrote:
> On Thu, Dec 05, 2024 at 08:26:05PM -0500, Mingwei Zheng wrote:
> > Add check for the return value of clk_enable() to catch the potential
> > error.
> > 
> > Fixes: e70a540b4e02 ("pwm: Add STM32 LPTimer PWM driver")
> > Signed-off-by: Mingwei Zheng <zmw12306 at gmail.com>
> > Signed-off-by: Jiasheng Jiang <jiashengjiangcool at gmail.com>
> 
> In reply to (implicit) v1 you wrote:
> > We detected this through static analysis, instead of actually hit.
> 
> Would be nice to mention the tool that actually found it in the commit
> log.
> 
> Otherwise I'm happy with that change now.
> 
> Given the issue is old (the offending commit is in v4.14-rc1), I'd note
> send it as a fix before v4.14. I'd send it along however if something
> more urgent pops up.

I wasn't very attentive when I wrote that mail, what I meant was:

Given the issue is old (the offending commit is in v4.14-rc1), I'd not
send it as a fix before v6.13. I'd send it along however if something
more urgent pops up.

Best regards
Uwe


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20241206/3180abf1/attachment.sig>


More information about the linux-arm-kernel mailing list