[PATCH] arm64: mte: Fix copy_highpage() warning on hugetlb folios

Catalin Marinas catalin.marinas at arm.com
Thu Dec 5 10:23:00 PST 2024


On Wed, 04 Dec 2024 17:50:04 +0000, Catalin Marinas wrote:
> Commit 25c17c4b55de ("hugetlb: arm64: add mte support") improved the
> copy_highpage() function to update the tags in the destination hugetlb
> folio. However, when the source folio isn't tagged, the code takes the
> non-hugetlb path where try_page_mte_tagging() warns as the destination
> is a hugetlb folio:
> 
>   WARNING: CPU: 0 PID: 363 at arch/arm64/include/asm/mte.h:58 copy_highpage+0x1d4/0x2d8
>   [...]
>   pc : copy_highpage+0x1d4/0x2d8
>   lr : copy_highpage+0x78/0x2d8
>   [...]
>   Call trace:
>    copy_highpage+0x1d4/0x2d8 (P)
>    copy_highpage+0x78/0x2d8 (L)
>    copy_user_highpage+0x20/0x48
>    copy_user_large_folio+0x1bc/0x268
>    hugetlb_wp+0x190/0x860
>    hugetlb_fault+0xa28/0xc10
>    handle_mm_fault+0x2a0/0x2c0
>    do_page_fault+0x12c/0x578
>    do_mem_abort+0x4c/0xa8
>    el0_da+0x44/0xb0
>    el0t_64_sync_handler+0xc4/0x138
>    el0t_64_sync+0x198/0x1a0
> 
> [...]

Applied to arm64 (for-next/fixes), thanks!

[1/1] arm64: mte: Fix copy_highpage() warning on hugetlb folios
      https://git.kernel.org/arm64/c/cf3b16dae4ca

-- 
Catalin




More information about the linux-arm-kernel mailing list