[PATCH] rtc: zynqmp: Fix optional clock name property

Peter Korsgaard peter at korsgaard.com
Wed Dec 4 05:09:29 PST 2024


On 11/27/24 17:01, Michal Simek wrote:
> Clock description in DT binding introduced by commit f69060c14431
> ("dt-bindings: rtc: zynqmp: Add clock information") is talking about "rtc"
> clock name but driver is checking "rtc_clk" name instead.
> Because clock is optional property likely in was never handled properly by
> the driver.
> 
> Fixes: 07dcc6f9c762 ("rtc: zynqmp: Add calibration set and get support")
> Signed-off-by: Michal Simek <michal.simek at amd.com>
> Cc: <stable at kernel.org>

Reviewed-by: Peter Korsgaard <peter at korsgaard.com>


>   drivers/rtc/rtc-zynqmp.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-zynqmp.c b/drivers/rtc/rtc-zynqmp.c
> index 08ed171bdab4..b6f96c10196a 100644
> --- a/drivers/rtc/rtc-zynqmp.c
> +++ b/drivers/rtc/rtc-zynqmp.c
> @@ -318,8 +318,8 @@ static int xlnx_rtc_probe(struct platform_device *pdev)
>   		return ret;
>   	}
>   
> -	/* Getting the rtc_clk info */
> -	xrtcdev->rtc_clk = devm_clk_get_optional(&pdev->dev, "rtc_clk");
> +	/* Getting the rtc info */
> +	xrtcdev->rtc_clk = devm_clk_get_optional(&pdev->dev, "rtc");
>   	if (IS_ERR(xrtcdev->rtc_clk)) {
>   		if (PTR_ERR(xrtcdev->rtc_clk) != -EPROBE_DEFER)
>   			dev_warn(&pdev->dev, "Device clock not found.\n");

-- 
Bye, Peter Korsgaard




More information about the linux-arm-kernel mailing list