[RFC PATCH 05/14] KVM: arm64: Always allow fixed cycle counter
Oliver Upton
oliver.upton at linux.dev
Tue Dec 3 14:32:38 PST 2024
On Tue, Dec 03, 2024 at 09:32:10PM +0000, Marc Zyngier wrote:
> On Tue, 03 Dec 2024 19:32:11 +0000,
> Oliver Upton <oliver.upton at linux.dev> wrote:
> >
> > The fixed CPU cycle counter is mandatory for PMUv3, so it doesn't make a
> > lot of sense allowing userspace to filter it. Only apply the PMU event
> > filter to *programmed* event counters.
>
> But that's a change in ABI, isn't it? We explicitly say in the
> documentation that the cycle counter can be filtered by specifying
> event 0x11.
Yeah... A bit of a dirty shortcut I took because I don't like the ABI,
but distaste isn't enough to break it :)
> More importantly, the current filtering works in terms of events, and
> not in terms of counters.
>
> Instead of changing the ABI, how about simply not supporting filtering
> on such non-compliant HW? Surely that would simplify a few things.
Yeah, that sounds reasonable. Especially if we allow programmable event
counters where the event ID space doesn't match the architecture.
--
Thanks,
Oliver
More information about the linux-arm-kernel
mailing list