[PATCH 4/7] arm64: dts: broadcom: Fix device tree warnings for BCM2712 display pipeline
Maxime Ripard
mripard at kernel.org
Mon Dec 2 07:24:31 PST 2024
On Mon, Dec 02, 2024 at 04:20:46PM +0100, Krzysztof Kozlowski wrote:
> On 02/12/2024 15:31, Dave Stevenson wrote:
> > Fixes up errors on HDMI and interrupt controllers that weren't
>
> What errors? I can't find anything in the commit. Describe the error.
>
> > noticed before merging.
> >
> > Fixes: de9bc2dba3db ("arm64: dts: broadcom: Add display pipeline support to BCM2712")
> > Signed-off-by: Dave Stevenson <dave.stevenson at raspberrypi.com>
> > ---
> > arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
> > index 39305e0869ec..f42fad2d8b37 100644
> > --- a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
> > +++ b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
> > @@ -336,7 +336,7 @@ ddc1: i2c at 7d508280 {
> > #size-cells = <0>;
> > };
> >
> > - bsc_irq: intc at 7d508380 {
> > + bsc_irq: interrupt-controller at 7d508380 {
>
>
> Do not mix cleanups with bugfixes.
>
> BTW, do not mix DTS to DRM. DRM has its own development style. DTS
> *cannot* be merged there, so combining these series is not welcomed and
> leads to issues (like DRM applying DTS!).
When did that ever happen?
Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 273 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20241202/6608b98e/attachment.sig>
More information about the linux-arm-kernel
mailing list