[PATCH net-next v2] net: stmmac: drop the ethtool begin() callback
Alexander Lobakin
aleksander.lobakin at intel.com
Fri Aug 30 06:35:00 PDT 2024
From: Andrew Halaney <ahalaney at redhat.com>
Date: Thu, 29 Aug 2024 15:48:44 -0500
> This callback doesn't seem to serve much purpose, and prevents things
> like:
>
> - systemd.link files from disabling autonegotiation
> - carrier detection in NetworkManager
> - any ethtool setting
>
> prior to userspace bringing the link up.
>
> The only fear I can think of is accessing unclocked resources due to
> pm_runtime, but ethtool ioctls handle that as of commit
> f32a21376573 ("ethtool: runtime-resume netdev parent before ethtool ioctl ops")
>
> Reviewed-by: Dmitry Dolenko <d.dolenko at metrotek.ru>
> Tested-by: Dmitry Dolenko <d.dolenko at metrotek.ru>
Reviewed-by: Alexander Lobakin <aleksander.lobakin at intel.com>
> Signed-off-by: Andrew Halaney <ahalaney at redhat.com>
Thanks,
Olek
More information about the linux-arm-kernel
mailing list