[PATCH] ARM: dts: stm32: Describe PHY LEDs in DH STM32MP13xx DHCOR DHSBC board DT

[Alexandre TORGUE]

Hi Marek

On 7/5/24 23:53, Marek Vasut wrote:
> The RTL8211 PHY on DH STM32MP13xx DHCOR DHSBC carrier board supports HW
> LED offload, the LEDs can be configured on link at 10/100/1000 line rate
> and on RXTX activity. There are two PHYs on this board, each only has two
> out of three LEDs connected to the PHY LED outputs. Describe this hardware
> configuration in DT.
> 
> Signed-off-by: Marek Vasut <marex at denx.de>
> ---
> Cc: Alexandre Torgue <alexandre.torgue at foss.st.com>
> Cc: Christophe Roullier <christophe.roullier at foss.st.com>
> Cc: Conor Dooley <conor+dt at kernel.org>
> Cc: Krzysztof Kozlowski <krzk+dt at kernel.org>
> Cc: Maxime Coquelin <mcoquelin.stm32 at gmail.com>
> Cc: Rob Herring <robh at kernel.org>
> Cc: devicetree at vger.kernel.org
> Cc: kernel at dh-electronics.com
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-stm32 at st-md-mailman.stormreply.com
> ---
>   .../boot/dts/st/stm32mp135f-dhcor-dhsbc.dts   | 38 +++++++++++++++++++
>   1 file changed, 38 insertions(+)
> 

I have a yaml validation issue applying this patch.

   DTC_CHK arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dtb
/local/home/frq08678/STLINUX/kernel/my-kernel/stm32/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dtb: 
ethernet-phy at 1: Unevaluated properties are not allowed 
('interrupt-parent', 'interrupts', 'reg', 'reset-assert-us', 
'reset-deassert-us', 'reset-gpios' were unexpected)
	from schema $id: http://devicetree.org/schemas/net/realtek,rtl82xx.yaml#
/local/home/frq08678/STLINUX/kernel/my-kernel/stm32/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dtb: 
ethernet-phy at 1: leds:led at 0:linux,default-trigger: 'oneOf' conditional 
failed, one must be fixed:
	'netdev' is not one of ['backlight', 'default-on', 'heartbeat', 
'disk-activity', 'disk-read', 'disk-write', 'timer', 'pattern', 
'audio-micmute', 'audio-mute', 'bluetooth-power', 'flash', 
'kbd-capslock', 'mtd', 'nand-disk', 'none', 'torch', 'usb-gadget', 
'usb-host', 'usbport']
	'netdev' does not match '^cpu[0-9]*$'
	'netdev' does not match '^hci[0-9]+-p

Can you have a look please ?


> diff --git a/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts b/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts
> index 1b916c419e8e2..c80a6ecdb47a6 100644
> --- a/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts
> +++ b/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts
> @@ -100,6 +100,25 @@ ethphy1: ethernet-phy at 1 {
>   			reset-assert-us = <15000>;
>   			reset-deassert-us = <55000>;
>   			reset-gpios = <&gpioa 11 GPIO_ACTIVE_LOW>;
> +
> +			leds {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				led at 0 {
> +					reg = <0>;
> +					color = <LED_COLOR_ID_GREEN>;
> +					function = LED_FUNCTION_WAN;
> +					linux,default-trigger = "netdev";
> +				};
> +
> +				led at 1 {
> +					reg = <1>;
> +					color = <LED_COLOR_ID_YELLOW>;
> +					function = LED_FUNCTION_WAN;
> +					linux,default-trigger = "netdev";
> +				};
> +			};
>   		};
>   	};
>   };
> @@ -130,6 +149,25 @@ ethphy2: ethernet-phy at 1 {
>   			reset-assert-us = <15000>;
>   			reset-deassert-us = <55000>;
>   			reset-gpios = <&gpiog 8 GPIO_ACTIVE_LOW>;
> +
> +			leds {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				led at 0 {
> +					reg = <0>;
> +					color = <LED_COLOR_ID_GREEN>;
> +					function = LED_FUNCTION_LAN;
> +					linux,default-trigger = "netdev";
> +				};
> +
> +				led at 1 {
> +					reg = <1>;
> +					color = <LED_COLOR_ID_YELLOW>;
> +					function = LED_FUNCTION_LAN;
> +					linux,default-trigger = "netdev";
> +				};
> +			};
>   		};
>   	};
>   };