[PATCH net-next v4 3/8] net: phy: Use for_each_available_child_of_node_scoped()
Jinjie Ruan
ruanjinjie at huawei.com
Thu Aug 29 20:13:20 PDT 2024
Avoid need to manually handle of_node_put() by using
for_each_available_child_of_node_scoped(), which can simplfy code.
Reviewed-by: Andrew Lunn <andrew at lunn.ch>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron at huawei.com>
Signed-off-by: Jinjie Ruan <ruanjinjie at huawei.com>
---
v4:
- Rebased on the previous fix patch has been stripped out.
- Add Reviewed-by.
v3:
- Add Reviewed-by
v2
- Split into 2 patches.
---
drivers/net/phy/phy_device.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 8f5314c1fecc..7c4a09455493 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -3407,7 +3407,7 @@ static int of_phy_led(struct phy_device *phydev,
static int of_phy_leds(struct phy_device *phydev)
{
struct device_node *node = phydev->mdio.dev.of_node;
- struct device_node *leds, *led;
+ struct device_node *leds;
int err;
if (!IS_ENABLED(CONFIG_OF_MDIO))
@@ -3420,10 +3420,9 @@ static int of_phy_leds(struct phy_device *phydev)
if (!leds)
return 0;
- for_each_available_child_of_node(leds, led) {
+ for_each_available_child_of_node_scoped(leds, led) {
err = of_phy_led(phydev, led);
if (err) {
- of_node_put(led);
phy_leds_unregister(phydev);
return err;
}
--
2.34.1
More information about the linux-arm-kernel
mailing list