[PATCH net-next v2 03/13] net: dsa: realtek: Use for_each_child_of_node_scoped()
Jinjie Ruan
ruanjinjie at huawei.com
Tue Aug 27 20:23:33 PDT 2024
Avoid need to manually handle of_node_put() by using
for_each_child_of_node_scoped(), which can simplfy code.
Signed-off-by: Jinjie Ruan <ruanjinjie at huawei.com>
---
v2:
- Split into 2 patches.
---
drivers/net/dsa/realtek/rtl8366rb.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/dsa/realtek/rtl8366rb.c b/drivers/net/dsa/realtek/rtl8366rb.c
index 9e821b42e5f3..7001b8b1c028 100644
--- a/drivers/net/dsa/realtek/rtl8366rb.c
+++ b/drivers/net/dsa/realtek/rtl8366rb.c
@@ -1009,7 +1009,7 @@ static int rtl8366rb_setup_all_leds_off(struct realtek_priv *priv)
static int rtl8366rb_setup_leds(struct realtek_priv *priv)
{
- struct device_node *leds_np, *led_np;
+ struct device_node *leds_np;
struct dsa_switch *ds = &priv->ds;
struct dsa_port *dp;
int ret = 0;
@@ -1025,13 +1025,11 @@ static int rtl8366rb_setup_leds(struct realtek_priv *priv)
continue;
}
- for_each_child_of_node(leds_np, led_np) {
+ for_each_child_of_node_scoped(leds_np, led_np) {
ret = rtl8366rb_setup_led(priv, dp,
of_fwnode_handle(led_np));
- if (ret) {
- of_node_put(led_np);
+ if (ret)
break;
- }
}
of_node_put(leds_np);
--
2.34.1
More information about the linux-arm-kernel
mailing list