[PATCH V2 2/5] Add dso__is_pie prototype

Leo Yan leo.yan at arm.com
Tue Aug 27 12:29:18 PDT 2024


On 8/26/2024 10:35 PM, Steve Clevenger wrote:
> 
> Changes in V2:
>   - Updated mailing list distribution

Usually, we record the change history into the cover letter, or put it under
the line starting with `---` in the commit. This can avoid the change history
to be merged into the mainline.

> Add prototype to dso__is_pie() global.

Please squash the patch 02 into 01. Otherwise, the patch 01 will introduce
building regression:

util/symbol-elf.c:669:6: error: no previous prototype for ‘dso__is_pie’
[-Werror=missing-prototypes]
  669 | bool dso__is_pie(struct dso *dso)
      |      ^~~~~~~~~~~

Thanks,
Leo

> Signed-off-by: Steve Clevenger <scclevenger at os.amperecomputing.com>
> ---
>  tools/perf/util/symbol.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h
> index 3fb5d146d9b1..33ea2596ce31 100644
> --- a/tools/perf/util/symbol.h
> +++ b/tools/perf/util/symbol.h
> @@ -127,6 +127,7 @@ void dso__insert_symbol(struct dso *dso,
>                         struct symbol *sym);
>  void dso__delete_symbol(struct dso *dso,
>                         struct symbol *sym);
> +bool dso__is_pie(struct dso *dso);
> 
>  struct symbol *dso__find_symbol(struct dso *dso, u64 addr);
>  struct symbol *dso__find_symbol_nocache(struct dso *dso, u64 addr);
> --
> 2.25.1
> 



More information about the linux-arm-kernel mailing list