[PATCH -next 2/7] net: dsa: realtek: Use for_each_child_of_node_scoped() and __free()
Jinjie Ruan
ruanjinjie at huawei.com
Tue Aug 27 00:52:14 PDT 2024
Avoid need to manually handle of_node_put() by using
for_each_child_of_node_scoped() and __free(), which can simplfy code.
Signed-off-by: Jinjie Ruan <ruanjinjie at huawei.com>
---
drivers/net/dsa/realtek/rtl8366rb.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/net/dsa/realtek/rtl8366rb.c b/drivers/net/dsa/realtek/rtl8366rb.c
index 9e821b42e5f3..0acdcdd93ea2 100644
--- a/drivers/net/dsa/realtek/rtl8366rb.c
+++ b/drivers/net/dsa/realtek/rtl8366rb.c
@@ -1009,7 +1009,6 @@ static int rtl8366rb_setup_all_leds_off(struct realtek_priv *priv)
static int rtl8366rb_setup_leds(struct realtek_priv *priv)
{
- struct device_node *leds_np, *led_np;
struct dsa_switch *ds = &priv->ds;
struct dsa_port *dp;
int ret = 0;
@@ -1018,23 +1017,21 @@ static int rtl8366rb_setup_leds(struct realtek_priv *priv)
if (!dp->dn)
continue;
- leds_np = of_get_child_by_name(dp->dn, "leds");
+ struct device_node *leds_np __free(device_node) =
+ of_get_child_by_name(dp->dn, "leds");
if (!leds_np) {
dev_dbg(priv->dev, "No leds defined for port %d",
dp->index);
continue;
}
- for_each_child_of_node(leds_np, led_np) {
+ for_each_child_of_node_scoped(leds_np, led_np) {
ret = rtl8366rb_setup_led(priv, dp,
of_fwnode_handle(led_np));
- if (ret) {
- of_node_put(led_np);
+ if (ret)
break;
- }
}
- of_node_put(leds_np);
if (ret)
return ret;
}
--
2.34.1
More information about the linux-arm-kernel
mailing list