[PATCH v2] arm64: dts: ti: k3-am64* Disable ethernet by default at SoC level

Daniel Schultz d.schultz at phytec.de
Sun Aug 25 22:29:44 PDT 2024


Hey Logan,

my feedback is similar to Josua's.

On 09.08.24 15:57, Logan Bristol wrote:
> External interfaces should be disabled at the SoC DTSI level, since
> the node is incomplete. Disable Ethernet switch and ports in SoC DTSI
> and enable them in the board DTS. If the board DTS includes a SoM DTSI
> that completes the node description, enable the Ethernet switch and ports
> in SoM DTSI.
>
> Reflect this change in SoM DTSIs by removing ethernet port disable.
>
> Signed-off-by: Logan Bristol <logan.bristol at utexas.edu>
> ---
> Changes since v1:
> - Enabled cpsw3g and cpsw_port1 in SoM DTSI instead of board DTS
> if board DTS included SoM DTSI
> ---
>   arch/arm64/boot/dts/ti/k3-am64-main.dtsi               | 3 +++
>   arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi        | 6 ++----
>   arch/arm64/boot/dts/ti/k3-am642-evm.dts                | 3 +++
>   arch/arm64/boot/dts/ti/k3-am642-sk.dts                 | 3 +++
>   arch/arm64/boot/dts/ti/k3-am642-sr-som.dtsi            | 6 ++----
>   arch/arm64/boot/dts/ti/k3-am642-tqma64xxl-mbax4xxl.dts | 6 ++----
>   6 files changed, 15 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> index f8370dd03350..69c5af58b727 100644
> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> @@ -677,6 +677,7 @@ cpsw3g: ethernet at 8000000 {
>   		assigned-clock-parents = <&k3_clks 13 9>;
>   		clock-names = "fck";
>   		power-domains = <&k3_pds 13 TI_SCI_PD_EXCLUSIVE>;
> +		status = "disabled";
>   
>   		dmas = <&main_pktdma 0xC500 15>,
>   		       <&main_pktdma 0xC501 15>,
> @@ -701,6 +702,7 @@ cpsw_port1: port at 1 {
>   				phys = <&phy_gmii_sel 1>;
>   				mac-address = [00 00 00 00 00 00];
>   				ti,syscon-efuse = <&main_conf 0x200>;
> +				status = "disabled";
>   			};
>   
>   			cpsw_port2: port at 2 {
> @@ -709,6 +711,7 @@ cpsw_port2: port at 2 {
>   				label = "port2";
>   				phys = <&phy_gmii_sel 2>;
>   				mac-address = [00 00 00 00 00 00];
> +				status = "disabled";
>   			};
>   		};
>   
> diff --git a/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi b/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi
> index ea7c58fb67e2..6bece2fb4e95 100644
> --- a/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi
> @@ -185,6 +185,7 @@ AM64X_IOPAD(0x0278, PIN_INPUT, 7)	/* (C19) EXTINTn.GPIO1_70 */
>   &cpsw3g {
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&cpsw_rgmii1_pins_default>;
> +	status = "okay";
>   };
>   
>   &cpsw3g_mdio {
> @@ -208,10 +209,7 @@ cpsw3g_phy1: ethernet-phy at 1 {
>   &cpsw_port1 {
>   	phy-mode = "rgmii-rxid";
>   	phy-handle = <&cpsw3g_phy1>;
The connected phy is located on the SOM and should be enabled by default.
> -};
> -
> -&cpsw_port2 {
> -	status = "disabled";
> +	status = "okay";
>   };

This port is routed to the carrier-board. Please drop this node.

Regards,
Daniel




More information about the linux-arm-kernel mailing list