[PATCH v3 1/2] dt-bindings: arm: Add qcom,qmi-id for remote etm

[Jinlong Mao]

On 2024/8/23 15:39, Krzysztof Kozlowski wrote:
> On Fri, Aug 23, 2024 at 03:16:07PM +0800, Jinlong Mao wrote:
>>
>>
>> On 2024/8/22 15:41, Krzysztof Kozlowski wrote:
>>> On Wed, Aug 21, 2024 at 11:41:18PM -0700, Mao Jinlong wrote:
>>>> qcom,qmi-id is the instance id used by qmi API to communicate with
>>>> remote processor.
>>>>
>>>> Signed-off-by: Mao Jinlong <quic_jinlmao at quicinc.com>
>>>> ---
>>>>    .../bindings/arm/qcom,coresight-remote-etm.yaml        | 10 ++++++++++
>>>>    1 file changed, 10 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml
>>>> index 4fd5752978cd..27e5f18bfedf 100644
>>>> --- a/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml
>>>> +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml
>>>> @@ -20,6 +20,13 @@ properties:
>>>>      compatible:
>>>>        const: qcom,coresight-remote-etm
>>>> +  qcom,qmi-id:
>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>> +    description:
>>>> +      This id is used by qmi API to communicate with remote processor for
>>>> +      enabling and disabling remote etm. Each processor has its unique instance
>>>> +      id.
>>>> +
>>>>      out-ports:
>>>>        $ref: /schemas/graph.yaml#/properties/ports
>>>>        additionalProperties: false
>>>> @@ -31,6 +38,7 @@ properties:
>>>>    required:
>>>>      - compatible
>>>> +  - qcom,qmi-id
>>>
>>> That's an ABI break.
>>>
>>> Best regards,
>>> Krzysztof
>> Hi Krzysztof,
>>
>> Sorry, I didn't get your point.
>> Could you please share more details ?
> 
> Adding new required properties is an ABI break. Nothing in commit msg
> explained why this is okay or even needed.
> 
> Best regards,
> Krzysztof

Thank you. I will update in the commit msg.
>