[PATCH net-next v2 1/7] net: ti: icssg-prueth: Enable IEP1
Dan Carpenter
dan.carpenter at linaro.org
Thu Aug 22 04:32:50 PDT 2024
On Thu, Aug 22, 2024 at 11:22:44AM +0530, MD Danish Anwar wrote:
>
>
> On 21/08/24 5:23 pm, Roger Quadros wrote:
> >
> >
> > On 21/08/2024 14:33, Anwar, Md Danish wrote:
> >> Hi Roger,
> >>
> >> On 8/21/2024 4:57 PM, Roger Quadros wrote:
> >>> Hi,
> >>>
> >>> On 13/08/2024 10:42, MD Danish Anwar wrote:
> >>>> IEP1 is needed by firmware to enable FDB learning and FDB ageing.
> >>>
> >>> Required by which firmware?
> >>>
> >>
> >> IEP1 is needed by all ICSSG firmwares (Dual EMAC / Switch / HSR)
> >>
> >>> Does dual-emac firmware need this?
> >>>
> >>
> >> Yes, Dual EMAC firmware needs IEP1 to enabled.
> >
> > Then this need to be a bug fix?
>
> Correct, this is in fact a bug. But IEP1 is also needed by HSR firmware
> so I thought of keeping this patch with HSR series. As HSR will be
> completely broken if IEP1 is not enabled.
>
> I didn't want to post two patches one as bug fix to net and one part of
> HSR to net-next thus I thought of keeping this patch in this series only.
>
> > What is the impact if IEP1 is not enabled for dual emac.
> >
>
> Without IEP1 enabled, Crash is seen on AM64x 10M link when connecting /
> disconnecting multiple times. On AM65x IEP1 was always enabled because
> `prueth->pdata.quirk_10m_link_issue` was true. FDB learning and FDB
> ageing will also get impacted if IEP1 is not enabled.
>
Please could you add the information mentioned in this email into the commit
message?
regards,
dan carpenter
More information about the linux-arm-kernel
mailing list