[PATCH v3 1/3] dt-bindings: arm: qcom,coresight-static-replicator: Add property for source filtering
Krzysztof Kozlowski
krzk at kernel.org
Thu Aug 22 00:08:00 PDT 2024
On Wed, Aug 21, 2024 at 11:38:55AM +0100, Suzuki K Poulose wrote:
> On 21/08/2024 04:13, Tao Zhang wrote:
> > The is some "magic" hard coded filtering in the replicators,
> > which only passes through trace from a particular "source". Add
> > a new property "filter-src" to label a phandle to the coresight
> > trace source device matching the hard coded filtering for the port.
>
> Minor nit: Please do not use abbreviate "source" in the bindings.
> I am not an expert on other changes below and will leave it to
> Rob/Krzysztof to comment.
>
> Rob, Krzysztof,
>
> We need someway to "link" (add a phandle) from a "port". The patch below
> is extending "standard" port to add a phandle. Please let us know if
> there is a better way.
>
> e.g.:
>
> filters = list of tuples of port, phandle. ?
>
> e.g.:
>
> filters = < 0, <&tpdm_video>,
> 1, <&tpdm_mdss>
> >
>
Current solution feels like band-aid - what if next time you need some
second filter? Or "wall"? Or whatever? Next property?
Isn't filter just one endpoint in the graph?
A <--> filter <--> B
Instead of
A <----through-filter----> B?
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list