[PATCH v2] arm64: dts: imx8mm-emtop-baseboard: Add Peripherals Support

[Fabio Estevam]

Hi Tarang,

On Wed, Aug 21, 2024 at 10:58 AM Tarang Raval
<tarang.raval at siliconsignals.io> wrote:

> +       can-control {
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&pinctrl_cancontrol>;
> +               reset-gpios = <&gpio1 15 GPIO_ACTIVE_HIGH>;
> +       };

This does not have any compatible string, so this can-control block
should be removed.

> +        can: can at 0 {
> +                compatible = "microchip,mcp2515";
> +                pinctrl-names = "default";
> +                pinctrl-0 = <&pinctrl_canbus>;
> +                reg = <0>;

reg should come right after compatible.

> +       rtc at 32 {
> +               compatible = "rx8025";

This gives a warning as rx8025 does not exist.

It should be "epson,rx8025" instead.

> +/* Wifi */
> +&usdhc1 {
> +       pinctrl-names = "default", "state_100mhz", "state_200mhz";
> +       pinctrl-0 = <&pinctrl_usdhc1>, <&pinctrl_usdhc1_gpio>;
> +       pinctrl-1 = <&pinctrl_usdhc1_100mhz>, <&pinctrl_usdhc1_gpio>;
> +       pinctrl-2 = <&pinctrl_usdhc1_200mhz>, <&pinctrl_usdhc1_gpio>;

pinctrl_usdhc1_gpio is not being used as you only pass pinctrl-names =
"default". Remove pinctrl_usdhc1_gpio.

> +/* SD-card */
> +&usdhc2 {
> +        pinctrl-names = "default";
> +        pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
> +        pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_gpio>;
> +        pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_gpio>;

pinctrl_usdhc2_gpio is not being used as you only pass pinctrl-names =
"default". Remove pinctrl_usdhc2_gpio.

> +        cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
> +        bus-width = <4>;
> +        status = "okay";
> +};
> +
>  &iomuxc {
> +
> +       pinctrl_canbus: canbusgrp {
> +               fsl,pins = <
> +                       MX8MM_IOMUXC_GPIO1_IO14_GPIO1_IO14              0x14
> +               >;
> +       };

Please add blank lines to separate the pinctrl groups.

> +       pinctrl_cancontrol: cancontrolgrp {