[net-next v4 4/5] net: stmmac: Add PCI driver support for BCM8958x
Jitendra Vegiraju
jitendra.vegiraju at broadcom.com
Tue Aug 20 16:16:22 PDT 2024
On Fri, Aug 16, 2024 at 11:27 AM Jakub Kicinski <kuba at kernel.org> wrote:
>
> On Wed, 14 Aug 2024 15:18:17 -0700 jitendra.vegiraju at broadcom.com wrote:
> > + pci_restore_state(pdev);
> > + pci_set_power_state(pdev, PCI_D0);
> > +
> > + ret = pci_enable_device(pdev);
> > + if (ret)
> > + return ret;
> > +
> > + pci_set_master(pdev);
>
> pci_restore_state() doesn't restore master and enable?
Hi Jakub,
Thanks for the feedback. You are correct, The pci_enable_device() and
pci_set_master() calls are not necessary.
We did more testing without these calls.
We will remove the calls.
Thanks
More information about the linux-arm-kernel
mailing list