[PATCH v1] drivers:spi:Insert the missing pci_dev_put()before return

Yang Ruibin 11162571 at vivo.com
Tue Aug 20 04:12:35 PDT 2024


Increase the reference count by calling pci_get_slot(), and remember to 
decrement the reference count by calling pci_dev_put().

Signed-off-by: Yang Ruibin <11162571 at vivo.com>
---
 drivers/spi/spi-pxa2xx-pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-pxa2xx-pci.c b/drivers/spi/spi-pxa2xx-pci.c
index 72bccb3b5..d49d8fef4 100644
--- a/drivers/spi/spi-pxa2xx-pci.c
+++ b/drivers/spi/spi-pxa2xx-pci.c
@@ -145,7 +145,7 @@ static int lpss_spi_setup(struct pci_dev *dev, struct pxa2xx_spi_controller *c)
 	c->num_chipselect = 1;
 
 	ret = pxa2xx_spi_pci_clk_register(dev, ssp, 50000000);
-	if (ret)
+	if (ret) {
+		pci_dev_put(dma_dev);
 		return ret;
+	}
@@ -223,7 +223,7 @@ static int mrfld_spi_setup(struct pci_dev *dev, struct pxa2xx_spi_controller *c)
 	}
 
 	ret = pxa2xx_spi_pci_clk_register(dev, ssp, 25000000);
-	if (ret)
+	if (ret) {
+		pci_dev_put(dma_dev);
 		return ret;
+	}
-- 
2.34.1




More information about the linux-arm-kernel mailing list