[PATCH net-next v2 4/7] net: ti: icssg-prueth: Add support for HSR frame forward offload
Anwar, Md Danish
a0501179 at ti.com
Mon Aug 19 00:16:07 PDT 2024
On 8/15/2024 8:44 PM, Simon Horman wrote:
> On Tue, Aug 13, 2024 at 01:12:30PM +0530, MD Danish Anwar wrote:
>
> ...
>
>> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.h b/drivers/net/ethernet/ti/icssg/icssg_prueth.h
>> index f678d656a3ed..40bc3912b6ae 100644
>> --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.h
>> +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.h
>> @@ -239,6 +239,7 @@ struct icssg_firmwares {
>> * @iep1: pointer to IEP1 device
>> * @vlan_tbl: VLAN-FID table pointer
>> * @hw_bridge_dev: pointer to HW bridge net device
>> + * @hsr_dev: pointer to the HSR net device
>> * @br_members: bitmask of bridge member ports
>> * @prueth_netdevice_nb: netdevice notifier block
>> * @prueth_switchdev_nb: switchdev notifier block
>
> I think you also need to add Kernel doc entries for @hsr_members and
> @is_hsr_offload_mode.
>
> Flagged by W=1 builds and ./scripts/kernel-doc -none
Sure Simon, I'll do that.
>
>> @@ -274,11 +275,14 @@ struct prueth {
>> struct prueth_vlan_tbl *vlan_tbl;
>>
>> struct net_device *hw_bridge_dev;
>> + struct net_device *hsr_dev;
>> u8 br_members;
>> + u8 hsr_members;
>> struct notifier_block prueth_netdevice_nb;
>> struct notifier_block prueth_switchdev_nb;
>> struct notifier_block prueth_switchdev_bl_nb;
>> bool is_switch_mode;
>> + bool is_hsr_offload_mode;
>> bool is_switchmode_supported;
>> unsigned char switch_id[MAX_PHYS_ITEM_ID_LEN];
>> int default_vlan;
>> --
>> 2.34.1
>>
--
Thanks and Regards,
Md Danish Anwar
More information about the linux-arm-kernel
mailing list