[PATCH net-next v10 11/13] net: phy: add driver for built-in 2.5G ethernet PHY on MT7988

[Andrew Lunn]

> +static int mt798x_2p5ge_phy_config_aneg(struct phy_device *phydev)
> +{
> +	bool changed = false;
> +	u32 adv;
> +	int ret;
> +
> +	/* In fact, if we disable autoneg, we can't link up correctly:
> +	 * 2.5G/1G: Need AN to exchange master/slave information.
> +	 * 100M/10M: Without AN, link starts at half duplex (According to
> +	 *           IEEE 802.3-2018), which this phy doesn't support.
> +	 */
> +	if (phydev->autoneg == AUTONEG_DISABLE)
> +		return -EOPNOTSUPP;

I assume you have seen Russells patches in this area. Please could you
test and review them. Depending on which gets merged, you might need
to come back and clean this up later.

   Andrew