[PATCH v1 1/1] ACPI/IORT: Switch to use kmemdup_array()

Hanjun Guo guohanjun at huawei.com
Fri Aug 9 05:52:52 PDT 2024


On 2024/8/9 20:16, Andy Shevchenko wrote:
> On Fri, Jun 14, 2024 at 08:54:39AM +0800, Hanjun Guo wrote:
>> +Cc Catalin
>>
>> On 2024/6/11 18:42, Hanjun Guo wrote:
>>> On 2024/6/7 0:50, Andy Shevchenko wrote:
>>>> Let the kememdup_array() take care about multiplication and possible
>>>> overflows.
>>>>
>>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
>>>> ---
>>>>    drivers/acpi/arm64/iort.c | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
>>>> index c0b1c2c19444..e596dff20f1e 100644
>>>> --- a/drivers/acpi/arm64/iort.c
>>>> +++ b/drivers/acpi/arm64/iort.c
>>>> @@ -822,7 +822,7 @@ static struct iommu_iort_rmr_data *iort_rmr_alloc(
>>>>            return NULL;
>>>>        /* Create a copy of SIDs array to associate with this rmr_data */
>>>> -    sids_copy = kmemdup(sids, num_sids * sizeof(*sids), GFP_KERNEL);
>>>> +    sids_copy = kmemdup_array(sids, num_sids, sizeof(*sids),
>>>> GFP_KERNEL);
>>>>        if (!sids_copy) {
>>>>            kfree(rmr_data);
>>>>            return NULL;
>>>
>>> Looks good to me,
>>>
>>> Acked-by: Hanjun Guo <guohanjun at huawei.com>
>>
>> Catalin, would you mind pick this up as well?
> 
> Any news?
> 
> I do not see this even in Linux Next...

Sudeep, Lorenzo, would you mind giving it a go?

Thanks
Hanjun



More information about the linux-arm-kernel mailing list