[PATCH] ARM: dts: microchip: sam9x60: Move i2c address/size to dtsi

claudiu beznea claudiu.beznea at tuxon.dev
Thu Aug 8 23:15:03 PDT 2024



On 28.05.2024 18:31, Alexander Dahl wrote:
> These properties are common for all i2c subnodes, and marked as
> 'required' in atmel/microchip i2c bindings.  Allows to add i2c device
> nodes (like an rtc for example) in other .dts files including
> sam9x60.dtsi without requiring to repeat these properties for each i2c
> device again and again.
> 
> Found on a custom board after adding this in .dts:
> 
>     &flx5 {
>             atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_TWI>;
>             status = "okay";
> 
>             i2c5: i2c at 600 {
>                     pinctrl-0 = <&pinctrl_flx5_default>;
>                     status = "okay";
> 
>                     pcf8523: rtc at 68 {
>                             compatible = "nxp,pcf8523";
>                             reg = <0x68>;
>                     };
>             };
>     };
> 
> … which created a warning like this:
> 
>     […]:236.4-17: Warning (reg_format): 
> /ahb/apb/flexcom at f0004000/i2c at 600/rtc at 68:reg: property has invalid 
> length (4 bytes) (#address-cells == 2, #size-cells == 1)
>     […]: Warning (pci_device_reg): Failed prerequisite 'reg_format'
>     […]: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
>     […]: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
>     
> […]/linux-6.6.25/arch/arm/boot/dts/microchip/sam9x60.dtsi:283.19-299.7: 
> Warning (i2c_bus_bridge): /ahb/apb/flexcom at f0004000/i2c at 600: incorrect 
> #address-cells for I2C bus also defined at […]:228.16-238.4
>     
> […]/linux-6.6.25/arch/arm/boot/dts/microchip/sam9x60.dtsi:283.19-299.7: 
> Warning (i2c_bus_bridge): /ahb/apb/flexcom at f0004000/i2c at 600: incorrect 
> #size-cells for I2C bus also defined at […]:228.16-238.4
>     […]: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
>     […]: Warning (i2c_bus_reg): Failed prerequisite 'i2c_bus_bridge'
>     […]: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
>     […]:234.19-237.5: Warning (avoid_default_addr_size): 
> /ahb/apb/flexcom at f0004000/i2c at 600/rtc at 68: Relying on default 
> #address-cells value
>     […]:234.19-237.5: Warning (avoid_default_addr_size): 
> /ahb/apb/flexcom at f0004000/i2c at 600/rtc at 68: Relying on default #size-cells
>  value
>     […]: Warning (avoid_unnecessary_addr_size): Failed prerequisite 
> 'avoid_default_addr_size'
>     […]: Warning (unique_unit_address): Failed prerequisite 
> 'avoid_default_addr_size'
> 
> This probably should have been done with commit 84f23f3284d5 ("ARM: dts:
> at91: sam9x60: move flexcom definitions") already, where those
> address-cells and size-cells properties were left in the board .dts
> files instead of moving them to the dtsi.
> 
> Signed-off-by: Alexander Dahl <ada at thorsis.com>


Applied to at91-dt, thanks!

Please note that I've adjusted the commit message to reflect that the props
you've adjusted are not required anymore in the validation schema.

Thank you,
Claudiu Beznea



More information about the linux-arm-kernel mailing list