[PATCH 1/1] arm64: dts: lx2160a: Change PCIe compatible string to fsl,ls2088a-pcie

[Conor Dooley]

On Thu, Aug 08, 2024 at 11:51:34AM -0400, Frank Li wrote:
> On Thu, Aug 08, 2024 at 04:34:32PM +0100, Conor Dooley wrote:
> > On Thu, Aug 08, 2024 at 11:31:20AM -0400, Frank Li wrote:
> > > The mass production lx2160 rev2 use designware PCIe Controller. Old Rev1
> > > which use mobivel PCIe controller was not supported. Although uboot
> > > fixup can change compatible string fsl,lx2160a-pcie to fsl,ls2088a-pcie
> > > since 2019, it is quite confused and should correctly reflect hardware
> > > status in fsl-lx2160a.dtsi.
> >
> > This does not begin to explain why removing the soc-specific compatible,
> > and instead putting the compatible for another soc is the right fix.
> > Come up with a new compatible for this device, that perhaps falls back
> > to the ls2088a, but this change doesn't seem right to me.
> 
> It can't fallback to fsl,ls2088a-pcie if fsl,lx2160a-pcie exist, which are
> totally imcompatible between fsl,ls2088a-pcie and fsl,lx2160a-pcie.
> 
> Previous dtb can work just because uboot dynamtic change fsl,lx2160a-pcie
> to fsl,ls2088a-pcie when boot kernel.
> 
> fsl,lx2160a-pcie should be removed because Rev1 have not mass productioned.

Please re-read what I wrote. I said to come up with a new compatible for
this device, not fall back from the existing fsl,lx2160a-pcie to
fsl,ls2088a-pcie.

Thanks,
Conor.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20240808/eb255cd9/attachment.sig>