[PATCH v2 1/3] dt-bindings: clock: exynosautov9: add dpum clock
Kwanghoon Son
kwangson at yahoo.com
Thu Aug 8 02:51:34 PDT 2024
On Thu, 2024-08-08 at 09:57 +0200, Krzysztof Kozlowski wrote:
> On 30/07/2024 13:15, Kwanghoon Son wrote:
> > Add dpum clock definitions and compatibles.
> >
> > Signed-off-by: Kwanghoon Son <k.son at samsung.com>
> > ---
> > .../clock/samsung,exynosautov9-clock.yaml | 19 +++++++++++++++++++
> > .../dt-bindings/clock/samsung,exynosautov9.h | 11 +++++++++++
> > 2 files changed, 30 insertions(+)
>
> > +
> > + then:
> > + properties:
> > + clocks:
> > + items:
> > + - description: External reference clock (26 MHz)
> > + - description: CMU_DPUM bus clock (from CMU_TOP)
> > +
> > + clock-names:
> > + items:
> > + - const: oscclk
> > + - const: dout_clkcmu_dpum_bus
>
> We need to stop calling input clocks by full name. Rob already pointed
> it out for GS101 and we fixed the approach there. This binding already
> uses above syntax, but I think we can start with proper approach even if
> it leads to inconsistency. So please come with description of this clock
> (not clock name - see GS101) and name, e.g. "bus".
True. I'll look over GS101 more and work in v3.
>
> BTW, in the future, please ping after two weeks or better even: relax,
> and help out by reviewing other patches on the mailing lists in order to
> relieve the burden of maintainers and move your patches higher up the list.
I'll keep in mind.
Thanks for advice.
Kwang.
>
> Best regards,
> Krzysztof
>
More information about the linux-arm-kernel
mailing list