[PATCH v3 2/2] tty: serial: samsung_tty: cast the interrupt's void *id just once

Jiri Slaby jirislaby at kernel.org
Thu Aug 8 01:35:26 PDT 2024


On 08. 08. 24, 10:11, André Draszik wrote:
> The interrupt handler routines and helpers are casting the 'void *'
> pointer to 'struct exynos_uart_port *' all over the place.
> 
> There is no need for that, we can do the casting once and keep passing
> the 'struct exynos_uart_port *', simplifying the code and saving a few
> lines of code.
> 
> No functional changes.
> 
> Reviewed-by: Tudor Ambarus <tudor.ambarus at linaro.org>
> Signed-off-by: André Draszik <andre.draszik at linaro.org>
> ---
> v3: undo too eager removal of 'const' where unnecessary (Jiri)

LGTM now

Reviewed-by: Jiri Slaby <jirislaby at kernel.org>

> v2: fix -Wdiscarded-qualifiers, sorry

thanks,
-- 
js
suse labs




More information about the linux-arm-kernel mailing list