[PATCH net] net: stmmac: dwmac4: fix PCS duplex mode decode
Abhishek Chauhan (ABC)
quic_abchauha at quicinc.com
Tue Aug 6 09:15:21 PDT 2024
On 7/3/2024 5:24 AM, Russell King (Oracle) wrote:
> dwmac4 was decoding the duplex mode from the GMAC_PHYIF_CONTROL_STATUS
> register incorrectly, using GMAC_PHYIF_CTRLSTATUS_LNKMOD_MASK (value 1)
> rather than GMAC_PHYIF_CTRLSTATUS_LNKMOD (bit 16). Fix this.
>
> Thanks to Abhishek Chauhan for providing a response on this issue.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel at armlinux.org.uk>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
> index b25774d69195..26d837554a2d 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
> @@ -791,7 +791,7 @@ static void dwmac4_phystatus(void __iomem *ioaddr, struct stmmac_extra_stats *x)
> else
> x->pcs_speed = SPEED_10;
>
> - x->pcs_duplex = (status & GMAC_PHYIF_CTRLSTATUS_LNKMOD_MASK);
> + x->pcs_duplex = (status & GMAC_PHYIF_CTRLSTATUS_LNKMOD);
>
> pr_info("Link is Up - %d/%s\n", (int)x->pcs_speed,
> x->pcs_duplex ? "Full" : "Half");
Thanks Russell for taking care of this change.
Can you please add my Reviewed-by: Abhishek Chauhan <quic_abchauha at quicinc.com> on the latest series.
Thanks
ABC
More information about the linux-arm-kernel
mailing list