[PATCH] arm64: Properly clean up iommu-dma remnants

Robin Murphy robin.murphy at arm.com
Tue Apr 30 04:00:54 PDT 2024


On 2024-04-30 11:32 am, Dmitry Baryshkov wrote:
> On Tue, 30 Apr 2024 at 13:23, Robin Murphy <robin.murphy at arm.com> wrote:
>>
>> Thanks to the somewhat asymmetrical nature, while removing
>> iommu_setup_dma_ops() from the arch_setup_dma_ops() flow, I managed to
>> forget that arm64's teardown path was also specific to iommu-dma. Clean
>> that up to match, otherwise probe deferral will lead to the arch code
>> erroneously removing DMA ops set elsewhere.
>>
>> Reported-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>> Link: https://lore.kernel.org/linux-iommu/Zi_LV28TR-P-PzXi@eriador.lumag.spb.ru/
>> Fixes: b67483b3c44e ("iommu/dma: Centralise iommu_setup_dma_ops()")
>> Signed-off-by: Robin Murphy <robin.murphy at arm.com>
>> ---
>>   arch/arm64/Kconfig          | 1 -
>>   arch/arm64/mm/dma-mapping.c | 8 --------
>>   2 files changed, 9 deletions(-)
> 
> 
> Thanks!
> 
> Tested-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>

Great! Always nice when the issue is one of simply not deleting *enough* 
code :)

Cheers,
Robin.



More information about the linux-arm-kernel mailing list