[PATCH 2/2] ARM: dts: BCM5301X: Describe PCIe controllers fully

[Florian Fainelli]

On 4/23/24 04:02, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal at milecki.pl>
> 
> This fixes:
> arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dtb: pcie at 18012000: 'device_type' is a required property
>          from schema $id: http://devicetree.org/schemas/pci/pci-bus.yaml#
> arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dtb: pcie at 18012000: 'ranges' is a required property
>          from schema $id: http://devicetree.org/schemas/pci/pci-bus.yaml#
> arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dtb: pcie at 18013000: 'device_type' is a required property
>          from schema $id: http://devicetree.org/schemas/pci/pci-bus.yaml#
> arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dtb: pcie at 18013000: 'ranges' is a required property
>          from schema $id: http://devicetree.org/schemas/pci/pci-bus.yaml#
> arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dtb: pcie at 18014000: 'device_type' is a required property
>          from schema $id: http://devicetree.org/schemas/pci/pci-bus.yaml#
> arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dtb: pcie at 18014000: 'ranges' is a required property
>          from schema $id: http://devicetree.org/schemas/pci/pci-bus.yaml#
> 
> Cc: Arınç ÜNAL <arinc.unal at arinc9.com>
> Signed-off-by: Rafał Miłecki <rafal at milecki.pl>

OK, so this is the rationale for patch #1, because you are adding a 
'ranges' property to each PCIe root complex node, and you need the 
values in the 'ranges' property to be expressed relative to the global 
address space, and not the axi at 18000000 address space, you needed to 
flatten the axi at 18000000 range.

Why not just bring those 3 nodes out of the axi at 18000000 node into the 
global address space then? That would greatly limit the amount of 
changes in patch #1, some of which are just unfortunate noise.

 From the chip diagram, each PCIe controller has its own separate AXI 
interface to the NIC 301 AXI fabric, so having 3 independent nodes which 
are not tied to the axi at 18000000 would not be wrong IMHO.

Thanks for doing this!
-- 
Florian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4221 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20240423/edc262bc/attachment.p7s>