[PATCH v7 07/11] ARM: mm: Type-annotate all per-processor assembly routines

Arnd Bergmann arnd at arndb.de
Sun Apr 21 23:00:18 PDT 2024


On Sun, Apr 21, 2024, at 20:28, Linus Walleij wrote:
> Type tag the remaining per-processor assembly using the CFI
> symbol macros, in addition to those that were previously tagged
> for cache maintenance calls.
>
> This will be used to finally provide proper C prototypes for
> all these calls as well so that CFI can be made to work.
>
> Tested-by: Kees Cook <keescook at chromium.org>
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>

The patch looks fine to me:

Acked-by: Arnd Bergmann <arnd at arndb.de>

> ---
>  arch/arm/mm/proc-arm1020.S   | 24 ++++++++++------
>  arch/arm/mm/proc-arm1020e.S  | 24 ++++++++++------
>  arch/arm/mm/proc-arm1022.S   | 24 ++++++++++------
>  arch/arm/mm/proc-arm1026.S   | 24 ++++++++++------
>  arch/arm/mm/proc-arm720.S    | 25 +++++++++++------
>  arch/arm/mm/proc-arm740.S    | 26 ++++++++++++-----
>  arch/arm/mm/proc-arm7tdmi.S  | 34 +++++++++++++++--------
>  arch/arm/mm/proc-arm920.S    | 31 ++++++++++++---------
>  arch/arm/mm/proc-arm922.S    | 23 +++++++++------
>  arch/arm/mm/proc-arm925.S    | 22 +++++++++------
>  arch/arm/mm/proc-arm926.S    | 31 +++++++++++++--------
>  arch/arm/mm/proc-arm940.S    | 21 +++++++++-----
>  arch/arm/mm/proc-arm946.S    | 21 +++++++++-----
>  arch/arm/mm/proc-arm9tdmi.S  | 26 ++++++++++++-----

I wonder if we should use the opportunity to clean out the
unused cores. Most of the above are not part of any SoC
in the kernel, the only ones that are actually used are
arm720 and arm92x, the arm10 variants are supported by
integrator but that is not really useful by itself.

       Arnd



More information about the linux-arm-kernel mailing list