[PATCH v6 10/11] ARM: hw_breakpoint: Handle CFI breakpoints

Linus Walleij linus.walleij at linaro.org
Fri Apr 19 05:56:33 PDT 2024


On Thu, Apr 18, 2024 at 6:13 PM Sami Tolvanen <samitolvanen at google.com> wrote:

> > +       switch (report_cfi_failure(regs, instruction_pointer(regs), &target, type)) {
>
> Nit: To make the error message a bit cleaner, you can use
> report_cfi_failure_noaddr(...) instead,

OK, fixed it!

> and maybe you can expand the
> comment to explain why target information isn't trivially available
> right now?

Sure, but I guess I would need you to explain it to me so I don't get
it wrong :D

Is it correct to say:

"TODO: To be able to properly extract target information the compiler
needs to be extended with operand bundling lowering into the 32-bit
ARM targets, and currently no compiler has implemented this."

?

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list