[PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP

Olivia Wen (温倩苓) Olivia.Wen at mediatek.com
Fri Apr 12 04:00:35 PDT 2024


Hi Krzysztof,

Thanks for the reviews.

On Thu, 2024-04-11 at 08:06 +0200, Krzysztof Kozlowski wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On 11/04/2024 05:37, olivia.wen wrote:
> > Under different applications, the MT8188 SCP can be used as single-
> core
> > or dual-core.
> > 
> > Signed-off-by: olivia.wen <olivia.wen at mediatek.com>
> 
> Are you sure you use full name, not email login as name?
> 

Thanks for the reminder. I have made changes.

> > ---
> >  Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git
> a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > index 507f98f..7e7b567 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > @@ -22,7 +22,7 @@ properties:
> >        - mediatek,mt8192-scp
> >        - mediatek,mt8195-scp
> >        - mediatek,mt8195-scp-dual
> > -
> > +      - mediatek,mt8188-scp-dual
> 
> Missing blank line, misordered.
> 

It will be corrected in the next version.

> >    reg:
> >      description:
> >        Should contain the address ranges for memory regions SRAM,
> CFG, and,
> > @@ -195,6 +195,7 @@ allOf:
> >          compatible:
> >            enum:
> >              - mediatek,mt8195-scp-dual
> > +            - mediatek,mt8188-scp-dual
> 
> Again, keep the order.
> 

It will be corrected in the next version.

> Best regards,a
> Krzysztof
> 
> 

Best regards,
Olivia


More information about the linux-arm-kernel mailing list