[PATCH] arm64: dts: debix-a: Remove i2c2 from base .dts

[Marco Felsch]

On 24-04-02, Laurent Pinchart wrote:
> Hi Marco,
> 
> On Tue, Apr 02, 2024 at 08:54:43AM +0200, Marco Felsch wrote:
> > On 24-03-26, Laurent Pinchart wrote:
> > > From: Jacopo Mondi <jacopo at jmondi.org>
> > > 
> > > The I2C2 bus is used for the CSI and DSI connectors only, no devices are
> > > connected to it on neither the Debix Model A nor its IO board. Remove
> > > the bus from the board's .dts and rely on display panel or camera sensor
> > > overlsy to enable it when necessary.
> > 
> > I would rather remove the status line instead of removing the whole node
> > since the bus is intented to be used for CSI and DSI and therefore the
> > muxing should be valid. This makes it easier for overlay authors since
> > they don't need to check the mux setup each time.
> 
> Seems sensible to me. I will drop the clock-frequency property in
> addition to the status property, as the frequency depends solely on the
> devices connected to the CSI and DSI connectors.

Make sense. With these changes, feel free to add my:

Reviewed-by: Marco Felsch <m.felsch at pengutronix.de>

Regards,
  Marco

> > > Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > > ---
> > >  .../boot/dts/freescale/imx8mp-debix-model-a.dts    | 14 --------------
> > >  1 file changed, 14 deletions(-)
> > > 
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts b/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts
> > > index 5ac77eaf23d5..26c303b7c7fa 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts
> > > @@ -210,13 +210,6 @@ ldo5: LDO5 {
> > >  	};
> > >  };
> > >  
> > > -&i2c2 {
> > > -	clock-frequency = <100000>;
> > > -	pinctrl-names = "default";
> > > -	pinctrl-0 = <&pinctrl_i2c2>;
> > > -	status = "okay";
> > > -};
> > > -
> > >  &i2c3 {
> > >  	clock-frequency = <400000>;
> > >  	pinctrl-names = "default";
> > > @@ -392,13 +385,6 @@ MX8MP_IOMUXC_I2C1_SDA__I2C1_SDA					0x400001c2
> > >  		>;
> > >  	};
> > >  
> > > -	pinctrl_i2c2: i2c2grp {
> > > -		fsl,pins = <
> > > -			MX8MP_IOMUXC_I2C2_SCL__I2C2_SCL					0x400001c2
> > > -			MX8MP_IOMUXC_I2C2_SDA__I2C2_SDA					0x400001c2
> > > -		>;
> > > -	};
> > > -
> > >  	pinctrl_i2c3: i2c3grp {
> > >  		fsl,pins = <
> > >  			MX8MP_IOMUXC_I2C3_SCL__I2C3_SCL					0x400001c2
> 
> -- 
> Regards,
> 
> Laurent Pinchart
>