[PATCH] firmware: arm_scmi: Do not use !! on boolean when setting msg->flags
Cristian Marussi
cristian.marussi at arm.com
Wed Sep 27 04:00:23 PDT 2023
On Thu, Sep 21, 2023 at 09:52:57AM +0100, Sudeep Holla wrote:
> Both pc->async_powercap_cap_set and ignore_dresp are already boolean.
> Use of !! on them is obviously dubious.
>
> Sparse reports:
> drivers/firmware/arm_scmi/powercap.c:363:17: warning: dubious: x & !y
> drivers/firmware/arm_scmi/powercap.c:363:17: warning: dubious: x & !y
>
Hi,
LGTM, indeed I was seeing that report too since a while, just I did not
realize why.
Reviewed-by: Cristian Marussi <cristian.marussi at arm.com>
Thanks,
Cristian
More information about the linux-arm-kernel
mailing list