[PATCH v3 08/13] KVM: arm64: Insert PS field at TCR_EL2 assembly time

Oliver Upton oliver.upton at linux.dev
Wed Sep 27 00:20:05 PDT 2023


'Assembly' is overloaded in this context, I had to reread the shortlog
to make sense of it. Maybe:

  KVM: arm64: Prepare TCR_EL2.PS in cpu_prepare_hyp_mode()

On Mon, Sep 18, 2023 at 07:57:35AM +0100, Ryan Roberts wrote:

[...]

>  	tcr &= ~TCR_T0SZ_MASK;
>  	tcr |= TCR_T0SZ(hyp_va_bits);
> +	tcr |= kvm_get_parange(mmfr0) << TCR_EL2_PS_SHIFT;

nit: FIELD_PREP() is slightly more defensive than shifting an unmasked
value.

-- 
Thanks,
Oliver



More information about the linux-arm-kernel mailing list