[EXT] [PATCH] arm64: dts: imx93: Fix the dmas entries order

Frank Li frank.li at nxp.com
Tue Sep 26 07:31:38 PDT 2023



> -----Original Message-----
> From: Fabio Estevam <festevam at gmail.com>
> Sent: Tuesday, September 26, 2023 9:19 AM
> To: shawnguo at kernel.org
> Cc: Frank Li <frank.li at nxp.com>; linux-arm-kernel at lists.infradead.org; Fabio
> Estevam <festevam at denx.de>
> Subject: [EXT] [PATCH] arm64: dts: imx93: Fix the dmas entries order
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> From: Fabio Estevam <festevam at denx.de>
> 
> Per fsl-lpuart.yaml, the dmas and dma-names entries should be
> 'rx' followed by 'tx'.

Does 'items' in yaml order matter? 

> 
> Change the order to fix the following schema warning:
> 
> imx93-11x11-evk.dtb: serial at 44380000: dma-names:0: 'rx' was expected
>         from schema $id:
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicet
> ree.org%2Fschemas%2Fserial%2Ffsl-
> lpuart.yaml%23&data=05%7C01%7CFrank.Li%40nxp.com%7Cec391aebaa364
> 3bb294808dbbe9b8c8a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> %7C638313347510781104%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLj
> AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%
> 7C%7C&sdata=ixPdTTT8vzQfWnAeK7afYaBEpElEW2sXi8o46CjstIg%3D&reserv
> ed=0
> imx93-11x11-evk.dtb: serial at 44380000: dma-names:1: 'tx' was expected
>         from schema $id:
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicet
> ree.org%2Fschemas%2Fserial%2Ffsl-
> lpuart.yaml%23&data=05%7C01%7CFrank.Li%40nxp.com%7Cec391aebaa364
> 3bb294808dbbe9b8c8a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> %7C638313347510781104%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLj
> AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%
> 7C%7C&sdata=ixPdTTT8vzQfWnAeK7afYaBEpElEW2sXi8o46CjstIg%3D&reserv
> ed=0
> 
> Signed-off-by: Fabio Estevam <festevam at denx.de>
> ---
>  arch/arm64/boot/dts/freescale/imx93.dtsi | 32 ++++++++++++------------
>  1 file changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
> b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index f20dd18e0b65..d6f6aeb7da74 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -336,8 +336,8 @@ lpuart1: serial at 44380000 {
>                                 interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
>                                 clocks = <&clk IMX93_CLK_LPUART1_GATE>;
>                                 clock-names = "ipg";
> -                               dmas = <&edma1 16 0 0>, <&edma1 17 0 1>;
> -                               dma-names = "tx", "rx";
> +                               dmas = <&edma1 17 0 1>, <&edma1 16 0 0>;
> +                               dma-names = "rx", "tx";
>                                 status = "disabled";
>                         };
> 
> @@ -347,8 +347,8 @@ lpuart2: serial at 44390000 {
>                                 interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
>                                 clocks = <&clk IMX93_CLK_LPUART2_GATE>;
>                                 clock-names = "ipg";
> -                               dmas = <&edma1 18 0 0>, <&edma1 19 0 1>;
> -                               dma-names = "tx", "rx";
> +                               dmas = <&edma1 19 0 1>, <&edma1 18 0 0>;
> +                               dma-names = "rx", "tx";
>                                 status = "disabled";
>                         };
> 
> @@ -669,8 +669,8 @@ lpuart3: serial at 42570000 {
>                                 interrupts = <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>;
>                                 clocks = <&clk IMX93_CLK_LPUART3_GATE>;
>                                 clock-names = "ipg";
> -                               dmas = <&edma2 17 0 0>, <&edma2 18 0 1>;
> -                               dma-names = "tx", "rx";
> +                               dmas = <&edma2 18 0 1>, <&edma2 17 0 0>;
> +                               dma-names = "rx", "tx";
>                                 status = "disabled";
>                         };
> 
> @@ -680,8 +680,8 @@ lpuart4: serial at 42580000 {
>                                 interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
>                                 clocks = <&clk IMX93_CLK_LPUART4_GATE>;
>                                 clock-names = "ipg";
> -                               dmas = <&edma2 19 0 0>, <&edma2 20 0 1>;
> -                               dma-names = "tx", "rx";
> +                               dmas = <&edma2 20 0 1>, <&edma2 19 0 0>;
> +                               dma-names = "rx", "tx";
>                                 status = "disabled";
>                         };
> 
> @@ -691,8 +691,8 @@ lpuart5: serial at 42590000 {
>                                 interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
>                                 clocks = <&clk IMX93_CLK_LPUART5_GATE>;
>                                 clock-names = "ipg";
> -                               dmas = <&edma2 21 0 0>, <&edma2 22 0 1>;
> -                               dma-names = "tx", "rx";
> +                               dmas = <&edma2 22 0 1>, <&edma2 21 0 0>;
> +                               dma-names = "rx", "tx";
>                                 status = "disabled";
>                         };
> 
> @@ -702,8 +702,8 @@ lpuart6: serial at 425a0000 {
>                                 interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
>                                 clocks = <&clk IMX93_CLK_LPUART6_GATE>;
>                                 clock-names = "ipg";
> -                               dmas = <&edma2 23 0 0>, <&edma2 24 0 1>;
> -                               dma-names = "tx", "rx";
> +                               dmas = <&edma2 24 0 1>, <&edma2 23 0 0>;
> +                               dma-names = "rx", "tx";
>                                 status = "disabled";
>                         };
> 
> @@ -742,8 +742,8 @@ lpuart7: serial at 42690000 {
>                                 interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_HIGH>;
>                                 clocks = <&clk IMX93_CLK_LPUART7_GATE>;
>                                 clock-names = "ipg";
> -                               dmas = <&edma2 87 0 0>, <&edma2 88 0 1>;
> -                               dma-names = "tx", "rx";
> +                               dmas = <&edma2 88 0 1>, <&edma2 87 0 0>;
> +                               dma-names = "rx", "tx";
>                                 status = "disabled";
>                         };
> 
> @@ -753,8 +753,8 @@ lpuart8: serial at 426a0000 {
>                                 interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>;
>                                 clocks = <&clk IMX93_CLK_LPUART8_GATE>;
>                                 clock-names = "ipg";
> -                               dmas = <&edma2 89 0 0>, <&edma2 90 0 1>;
> -                               dma-names = "tx", "rx";
> +                               dmas =  <&edma2 90 0 1>, <&edma2 89 0 0>;
> +                               dma-names = "rx", "tx";
>                                 status = "disabled";
>                         };
> 
> --
> 2.34.1




More information about the linux-arm-kernel mailing list