[PATCH] thermal: imx8mm_thermal: Fix function pointer declaration by adding identifier name

Daniel Lezcano daniel.lezcano at linaro.org
Mon Sep 25 00:47:21 PDT 2023


On 22/09/2023 11:31, Bragatheswaran Manickavel wrote:
> 
> On 17/09/23 14:04, Bragatheswaran Manickavel wrote:
>> Added identifier names to respective definitions for fix
>> warnings reported by checkpatch.pl
>>
>> WARNING: function definition argument 'void *' should also have an 
>> identifier name
>> WARNING: function definition argument 'int *' should also have an 
>> identifier name
>> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908 at gmail.com>
>> ---
>>   drivers/thermal/imx8mm_thermal.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/thermal/imx8mm_thermal.c 
>> b/drivers/thermal/imx8mm_thermal.c
>> index 14111ccf6e4c..5dc6c18f12df 100644
>> --- a/drivers/thermal/imx8mm_thermal.c
>> +++ b/drivers/thermal/imx8mm_thermal.c
>> @@ -78,7 +78,7 @@
>>   struct thermal_soc_data {
>>       u32 num_sensors;
>>       u32 version;
>> -    int (*get_temp)(void *, int *);
>> +    int (*get_temp)(void *data, int *temp);
>>   };
>>   struct tmu_sensor {
> 
> Hi Team, Could someone help in reviewing it.

Please no more "gentle reminder"

Read:

https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/tree/Documentation/process/submitting-patches.rst

Especially, the section _9_

Thanks

    -- Daniel

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog




More information about the linux-arm-kernel mailing list