[PATCH v4 1/5] lib/bitmap: add bitmap_{set,get}_value()

Alexander Potapenko glider at google.com
Fri Sep 22 00:49:55 PDT 2023


> OK. Can you put a comment explaining this? Or maybe would be even
> better to use BITMAP_LAST_WORD_MASK() here:
>
>          mask = BITMAP_LAST_WORD_MASK(nbits);
>          value &= mask;
>          ...
>          map[index] &= (fit ? (~mask << offset)) :

I changed GENMASK to BITMAP_LAST_WORD_MASK here, and I think it's
self-explanatory now, WDYT?



More information about the linux-arm-kernel mailing list